New updates and fixes

01 Octomber
Yay, leaving before starting the arena wouldn't decrease the players count xD
* [Shaman] Improved Reincarnation works now
* Improved Soul Siphon code, now it uses SKILL_AFFLICTION instead of mask
* Remember to reapply 1016_spellfixes.sql
Spell pushback interruptflags by instinkt


30 september
[Warlock] Demonic Resilience, damage reduction for pet should work now
Implemented [Warlock] Soul Siphon
Blessing of Freedom was making caster immune to frostbolts xD
[Paladin] Bleesed Life, when procing damage reduction it will count as resisted damage now, so it will get shown visually

28 september
[Warlock] Improved Health Funnel was making the warlock kill himself while casting health funnel, rofl xD
Don't allow player to login into a bg that has ended or is full
bleh, forgot a null check
27 september

Ghost Wolf form and Travel form are mounts? lol
* Improved split targets code, now it will split damage from dots as well
* Soul link, pet will not attack caster now when receiving damage
* Health Funnel now will really transfer hp instead of just healing pet for free
[Druid] Empowered Rejuvenation group relation. Rerun 1016_spellfixes.sql
NULL check and cleaned double check
[Warlock] Imrpoved Healthstone was increasing more than it should

26 september
Sorry for delay, but i was in a trip and didn't had time to post new updates...
[Warlock] Imrpoved Healthstone was increasing more than it should
[Rogue] Opportunity relation
[Warlock] Shadow Mastery, corrected groupRelation,
Corrected [Priest] Focused Power,
Slight changes to patch
Also another fix for vanish when the effect is gone you dont leave stealthed animation.

[Druid] Nature's Grace, based of http://arcemu.org/forums/index.php?showtopic=4490.
added a null check.
[Shaman] Lightning Shield and [Mage] Molten Armor now won't proc off DoTs, reapply 1016_spellfixes.sql as usual
[Druid] Tree of Life by redfake
Implemented SMT_THREAT_REDUCED, this willfix talents that reduce threat. Added [Druid] Subtlety group relation as well, remember to reapply 1016_spellfixes.sql

Improved arena queuing code, it's less exploitable now. Also fixed a bug with bg queues, this way it doesn't need two players from both sides always

.lookup Object command by chaoschief

Only one Corruption spell per Warlock can be active on any one target, based of http://arcemu.org/forums/index.php?showtopic=4492. NTY
Fix the .go rotate command. Added the ability to rotate on the x y and o axis properly.
Also when rotating or moving a object added reselecting of the objects new guid.
.go scale respawns with a new guid as it should properly do
scaling and rotating of the object it saved to the db.

[Priest] Searing Light relation, reapply 1016_spellfixes.sql

* dailies addition to r1078

this should let players attain daily quests even when they finished them when they weren't daily

* some spell fixes for Hex Lord Malacrass
* Victory Rush should time out now and proc in pve too

* elite mobs always hit??
* miss chance was wrongly applied to feral forms, 2h auto-attack, 2h abilities and dw abilities
Added some null checks
just another attempt to fix that can't leave combat bug. Accidentally noticed that creatures can enter combat state even if they are dead
lol should have merged all these commits
avoid a memory leak and another access violation.
let's avoid that access violation too if possible
better have this check here instead of a crash (cell related crashfix)
Fixed initialization for trigger_on_stun thx to seirge
Crashfixes for http://arcemu.org/forums/index.php?showtopic=4711, thx to seirge
Repeatables quests bugfix
blah, i forgot to revert this xD, logon shouldn't crash now
Priest:
- Vampiric Touch (Dead players cant be affected by VT)
Stealth aura stacking break flags (thx to jack)
DoTs shouldn't proc PROC_ON_SPELL_HIT, this will fix [Mage] Molten Armor and [Shaman] Lightning Shield procing off dots
Updated Arc's SVN location and added LearnALl function to the SpellForm
try to not have empty pools. Since there is this delayed double aura delete case. There is a chance that on edge of pool emptyness to pass the aura to a new owner while it is still active on old owner. Should be fixed properly. More like a test this version.
still don't understand how the damn inrange list gets corrupted. I added a lock on the list. In case i made a typo it will create deadlocks :S.
If you are one of those that get these kind of crashes then please give feedback on forum if situation changed.
correction 1064. Let's not add same variable 3 times . There is already : m_triggered and procedonspell if you need to test a triggered spell
you can give reason for banning an IP or account
Fixed typo, thx to Gaijin
[Shaman] Lightning overload is now more blizzlike. Remember to reapply 1016_spellfixes.sql
Corrections on the sockets changes, it should fix http://arcemu.org/forums/index.php?showtopic=4581
* First setup portion of Brewfest finished.
* First Commit
+ This will fix ap/cp modified damage of all combo-based spell effects (FEROCIOUS_BITE,EVISCERATE,RUPTURE,RIP, etc )

patches by 669
* Prevent duplicates in Spell::FillXXXTargetsXXX() functions, AKA spells hitting same player twice ( both positive and negative ).
* only intended spells can be cast reagent free while in preparation buff. Thanks to mangos team for this flag.
* incorrectly applied miss chance to feral forms
* lowering hp, mana and armor of WE
* fixed class and race in who list
f.e. /who 70 c-Mage r-Human
[Shaman] Elemental Fury, corrected groupRelation. Remeber to reapply 1016_spellfixes.sql
[Mage] Molten Armor does not require infront, just checked it
Priest:
- Mind Flay (reduces target's movement speed by 50%)
Fixed relation for [Paladin] Improved Seal of Righteousness
AURA_INTERRUPT_ON_INVINCIBLE now affects ice block, divine shield, blessing of protection, stealth and mage invisibility. This is the less hacky way to implement it so now wsg/eots flags behave more like on retail server
changed a little bit the extra strike code :
- extra strike should show in logs from what spell it is comming
- reckogning should not proc on reckogning (self proc ?)
NTY.
Rewrote extrastriketargets code, [Warrior] Sweeping strikes is more blizzlike now, won't get bugged sometimes and it's limited to 10 charges
Some improvements to sockets code, garbage collector is not used anymore, this makes arcemu less suseptible to attacks
changed a printf for sLog.outDebug, it was flooding my console
* deadlock, thx to Wayland
SpellEffectPowerDrain should actually drain power from the target, not just giving up power to the caster. This should fix [Warlock] Dark pact
Class trainers fix, Needed for that class trainers work fine with tracking by Sadikum
http://arcemu.org/forums/index.php?showtopic=4446
* when player picks up dropped flag in WSG, it's now properly announced
* aoe spells from mobs won't do double dmg
* fixed bug where dailies would act as repeatable
* increased respawn time of chests and other gameobjects
* object which don't contain quest loot shouldn't respawn in instances




19 september

AURA_INTERRUPT_ON_INVINCIBLE now affects ice block, divine shield, blessing of protection, stealth and mage invisibility. This is the less hacky way to implement it so now wsg/eots flags behave more like on retail server
Fixed relation for [Paladin] Improved Seal of Righteousness
Priest:
- Mind Flay (reduces target's movement speed by 50%)


18 september
Some improvements to sockets code, garbage collector is not used anymore, this makes arcemu less suseptible to attacks
Rewrote extrastriketargets code, [Warrior] Sweeping strikes is more blizzlike now, won't get bugged sometimes and it's limited to 10 charges
changed a little bit the extra strike code :
- extra strike should show in logs from what spell it is comming
- reckogning should not proc on reckogning (self proc ?)

channaled spells should not get interrupted because of combat state.
* removed hacky shadowfiend fix and replaced it with new, working one
* distance of summoned pets is taken from DBC
* increased respawn time of chests and other gameobjects
* object which don't contain quest loot shouldn't respawn in instances
* when player picks up dropped flag in WSG, it's now properly announced
* aoe spells from mobs won't do double dmg
* fixed bug where dailies would act as repeatable
Class trainers fix, Needed for that class trainers work fine with tracking by Sadikum
SpellEffectPowerDrain should actually drain power from the target, not just giving up power to the caster. This should fix [Warlock] Dark pact
* deadlock, thx to Wayland
changed a printf for sLog.outDebug, it was flooding my console


15 september
wands do not require ammo to work.
Save warlock pet names by whoami
GM .invis in battlegrounds and arenas by Gaijin
Resist dispel fix for [Paladin] Sanctified Seals


15 september
Instance mob and boss reputation fix by seirge
Fixed [Priest] Improved Power Word: Fortitude
o need to be in combat if dead. Might fix "can't leave combat" issue
[Warlock] Contagion should work properly now, reapplly 1016_spellfixes.sql as usual. I'm off to get some sleep now

Spellfixes: [Mage] Arcane Power, [Mage] Spell Power, [Priest] Force of Will and [Warlock] Master Demonologist
* [Rogue] Improved Kidney Shot, reapply 1016_spellfixes.sql
* Trade dupping exploit should be fixed now
* [Mage] Frostbite

[Druid] Feral Swiftness now gives correct amount of dodge chance in both talents (rank 1 and 2), they were swapped


14 september

[Druid] Feral Swiftness now gives correct amount of dodge chance in both talents (rank 1 and 2), they were swapped

Fixed [Warlock] Mana Feed, [Paladin] Divine Favor, [Paladin] Improved Concentration Aura and missing rank from Improved Bloodrage. I didn't add another .sql, just rerun 1016_spellfixes.sql

[Rogue] Cloak of Shadows should not resist Rend and phisical abilities

Fixed [Mage] Arcane Focus, [Mage] Elemental Precision, [Rogue] Surprise Attacks, [Rogue] Improved Sprint, [Hunter] Clever Traps and [Hunter] Barrage

Added Improved Charge, Improved Bloodrage, Impale, Improved Overpower (Untested but should be fine, gotta fix overpower )

spellfixes can now be reloaded with .server reloadtable spellfixes

Added -fomit-frame-pointer and -pipe when --enable-optimize is specified

* Arenas bugfix, if a player died and after that left the arena it would decrement count twice the playercount
* Missing ranks for infront with fire blast

container crashfix. OBJECTS MUST BE REMOVED FROM WORLD BEFORE WE DELETE THEM !

This might also influence the buildupdateblock crash in some cases.

crashfix. The ods to get this in real life were almost 0.

* Prevents resting players who are flagged for combat from logging out.
* Also prevents resting players who are in a duel from logging out.

Fixes 2 autoshoot problems.
1) When you ran out of ammo while shooting you didnt stop shooting.
2) When you started shooting then turned around facing away from your target you would keep shooting.

These are just a few patchs that I think could use some extra testing.

•Custom_Tables_Reload.patch Makes it so that if you declare Additional tables in your arcemu-world.conf file then when you .server reload <tablename> the Additional table is also reloaded.
• PerfectBlink.patch is blink at a near perfection state. At least the best its ever seen on a private server.
• FallingUnderWorld.patch this prevents players from being able to fall under -500z and getting stuck unless they jump off the edge of the outlands or something.

Hope this gets some testing

i fail in copy&paste

player sometimes stop attacking (like weaker mob died due to AOE)

* Cat, Bear and Dire Bear Form damage by Vanguard

* no crit animation for bosses
* increasing weapon skills was too slow >.>
(anyone knows proper formula btw? in best case one which includes intellect bonus too)

* Warlock's summonned pet levels up with owner by whoami

* Summons with TARGET_FLAG_DEST_LOCATION, Summon Wild, Guardian, Demon, Object by Gaijin